Fix 'getvalue' AttributeError when test fails during __call__ #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkanemoto
force-pushed
the
master
branch
2 times, most recently
from
328cff8 to
8fc1b97
Compare
tkanemoto
changed the title
tkanemoto
force-pushed
the
master
branch
3 times, most recently
from
208b817 to
fd9386f
Compare
|
|
|
|
|
|
|
|
added 2 commits
November 15, 2015 14:47
In some sub classes of TestCase where __call__() method is overridden, errors may occur that prevents the super class __call__ being called, e.g. Django's custom TestCase subclasses do pre-setup processing such as loading the fixture etc. which, on encountering exceptions, will skip calling __call__ on the super class, leaving sys.stdout and sys.stderr untouched. In the current implementation, this causes an unhandled AttributeError when trying to call .getvalue() on sys.stdout and sys.stderr. Refs: xmlrunner#83
sys.stdout and sys.sterr may not necessarily be StringIO yet. We should catch AttributeError when trying to call getvalue() on them. Fixes: xmlrunner#83
|
|
dnozay
added a commit
that referenced
this pull request
Nov 15, 2015
Fix 'getvalue' AttributeError when test fails during __call__
Member
|
thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys.stdout and sys.sterr may not necessarily be StringIO
yet. We should catch AttributeError when trying to call
getvalue() on them.
Fixes: #83